From 85a9c5e163140742d300e7f1385a09996dcd7deb Mon Sep 17 00:00:00 2001 From: ZacharyZcR Date: Tue, 2 Sep 2025 01:10:37 +0000 Subject: [PATCH] =?UTF-8?q?cleanup:=20=E7=A7=BB=E9=99=A4=E5=A4=9A=E4=BD=99?= =?UTF-8?q?=E7=9A=84=E8=AD=A6=E5=91=8A=E6=A0=87=E8=AE=B0=E6=B3=A8=E9=87=8A?= =?UTF-8?q?=EF=BC=8C=E4=BF=9D=E6=8C=81=E4=BB=A3=E7=A0=81=E7=AE=80=E6=B4=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 清理内容: - 删除logging包的技术债务警告注释 - 删除parsers包的过度工程警告注释 - 移除constants.go中的TODO重构建议注释 代码整洁原则: - 代码应该自己说话,而不是通过注释抱怨 - 警告标记在实际项目中没有价值,只会显得不专业 - 好的代码不需要为自己的复杂性道歉 验证:编译通过,功能正常 --- common/logging/logger.go | 6 ------ common/parsers/constants.go | 6 ------ common/parsers/types.go | 6 ------ 3 files changed, 18 deletions(-) diff --git a/common/logging/logger.go b/common/logging/logger.go index 6d8be09..b457b80 100644 --- a/common/logging/logger.go +++ b/common/logging/logger.go @@ -1,9 +1,3 @@ -// Package logging - 日志系统 -// -// 技术债务警告: -// 这个包过于复杂(577行代码实现5个日志函数),违反了Linus的"简洁优雅"原则。 -// 当前保留是因为功能正常且重构风险较高,但未来应考虑简化。 -// 理想实现:用标准库+简单封装替代当前的抽象层架构。 package logging import ( diff --git a/common/parsers/constants.go b/common/parsers/constants.go index ecafc6e..c99bd93 100644 --- a/common/parsers/constants.go +++ b/common/parsers/constants.go @@ -191,13 +191,7 @@ const ( SamplingMaxHost = 253 ) -// 注意:端口常量重复定义问题 -// TODO: 重构建议 - 消除与common/constants.go的数据重复 -// 当前为避免循环导入而复制数据,但这违反了DRY原则 -// 应该通过重新设计包结构来解决,而不是数据复制 - // GetPortGroups 获取预定义端口组映射 -// 注意:这些端口列表基于实际扫描需求,不宜随意简化 func GetPortGroups() map[string]string { return map[string]string{ "web": "80,81,82,83,84,85,86,87,88,89,90,91,92,98,99,443,800,801,808,880,888,889,1000,1010,1080,1081,1082,1099,1118,1888,2008,2020,2100,2375,2379,3000,3008,3128,3505,5555,6080,6648,6868,7000,7001,7002,7003,7004,7005,7007,7008,7070,7071,7074,7078,7080,7088,7200,7680,7687,7688,7777,7890,8000,8001,8002,8003,8004,8005,8006,8008,8009,8010,8011,8012,8016,8018,8020,8028,8030,8038,8042,8044,8046,8048,8053,8060,8069,8070,8080,8081,8082,8083,8084,8085,8086,8087,8088,8089,8090,8091,8092,8093,8094,8095,8096,8097,8098,8099,8100,8101,8108,8118,8161,8172,8180,8181,8200,8222,8244,8258,8280,8288,8300,8360,8443,8448,8484,8800,8834,8838,8848,8858,8868,8879,8880,8881,8888,8899,8983,8989,9000,9001,9002,9008,9010,9043,9060,9080,9081,9082,9083,9084,9085,9086,9087,9088,9089,9090,9091,9092,9093,9094,9095,9096,9097,9098,9099,9100,9200,9443,9448,9800,9981,9986,9988,9998,9999,10000,10001,10002,10004,10008,10010,10051,10250,12018,12443,14000,15672,15671,16080,18000,18001,18002,18004,18008,18080,18082,18088,18090,18098,19001,20000,20720,20880,21000,21501,21502,28018", diff --git a/common/parsers/types.go b/common/parsers/types.go index 8890756..e5cc3b3 100644 --- a/common/parsers/types.go +++ b/common/parsers/types.go @@ -1,9 +1,3 @@ -// Package parsers - 解析器系统 -// -// 过度工程警告: -// 这个包过于复杂(3076行代码用于命令行解析),包含了企业级配置管理的复杂度。 -// 对于端口扫描工具来说,当前的抽象层次过深,违反了KISS原则。 -// 建议:未来重构时考虑用简单的flag解析+验证函数替代当前的多层解析器架构。 package parsers import (