mirror of
https://github.com/shadow1ng/fscan.git
synced 2025-09-14 05:56:46 +08:00

经Linus式架构审计,发现并修复插件系统中的具体问题: ## 核心修复 ### 1. 消除local插件GetPorts()方法冗余 - 删除21个local插件中无意义的GetPorts()方法 - 简化local.Plugin接口:移除端口概念 - 理由:本地插件不涉及网络,端口概念完全多余 ### 2. 消除web插件GetPorts()方法冗余 - 删除2个web插件中无用的GetPorts()方法 - 简化web.WebPlugin接口:专注智能HTTP检测 - 理由:Web插件使用动态HTTP检测,预定义端口无价值 ### 3. 统一插件命名规范 - 统一所有插件接口使用Name()方法(符合Go惯例) - 消除GetName()与Name()不一致问题 - 简化适配器:不再需要方法名转换 ## 技术改进 接口精简: - local插件:GetName() + GetPorts() → Name() - web插件:GetName() + GetPorts() → Name() - services插件:GetName() → Name()(保留GetPorts(),业务必需) 代码减少: - 删除23个无用GetPorts()方法 - 重命名52个Name()方法 - 简化3个插件接口定义 ## 影响范围 修改文件:55个插件文件 代码变更:-155行 +61行(净减少94行) 功能影响:零破坏性,保持所有业务逻辑不变 这是基于业务需求分析的精准重构,消除真正多余的部分, 保持系统架构合理性和向后兼容性。
155 lines
3.4 KiB
Go
155 lines
3.4 KiB
Go
package services
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/gocql/gocql"
|
|
"github.com/shadow1ng/fscan/common"
|
|
)
|
|
|
|
type CassandraPlugin struct {
|
|
name string
|
|
ports []int
|
|
}
|
|
|
|
func NewCassandraPlugin() *CassandraPlugin {
|
|
return &CassandraPlugin{
|
|
name: "cassandra",
|
|
ports: []int{9042, 9160, 7000, 7001},
|
|
}
|
|
}
|
|
|
|
func (p *CassandraPlugin) Name() string {
|
|
return p.name
|
|
}
|
|
|
|
func (p *CassandraPlugin) GetPorts() []int {
|
|
return p.ports
|
|
}
|
|
|
|
func (p *CassandraPlugin) Scan(ctx context.Context, info *common.HostInfo) *ScanResult {
|
|
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
|
|
|
|
if common.DisableBrute {
|
|
return p.identifyService(ctx, info)
|
|
}
|
|
|
|
credentials := GenerateCredentials("cassandra")
|
|
if len(credentials) == 0 {
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "cassandra",
|
|
Error: fmt.Errorf("没有可用的测试凭据"),
|
|
}
|
|
}
|
|
|
|
for _, cred := range credentials {
|
|
if p.testCredential(ctx, info, cred) {
|
|
common.LogSuccess(fmt.Sprintf("Cassandra %s %s:%s", target, cred.Username, cred.Password))
|
|
|
|
return &ScanResult{
|
|
Success: true,
|
|
Service: "cassandra",
|
|
Username: cred.Username,
|
|
Password: cred.Password,
|
|
}
|
|
}
|
|
}
|
|
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "cassandra",
|
|
Error: fmt.Errorf("未发现弱密码"),
|
|
}
|
|
}
|
|
|
|
func (p *CassandraPlugin) testCredential(ctx context.Context, info *common.HostInfo, cred Credential) bool {
|
|
port, err := strconv.Atoi(info.Ports)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
cluster := gocql.NewCluster(info.Host)
|
|
cluster.Port = port
|
|
timeout := time.Duration(common.Timeout) * time.Second
|
|
cluster.Timeout = timeout
|
|
cluster.ConnectTimeout = timeout
|
|
|
|
if cred.Username != "" || cred.Password != "" {
|
|
cluster.Authenticator = gocql.PasswordAuthenticator{
|
|
Username: cred.Username,
|
|
Password: cred.Password,
|
|
}
|
|
}
|
|
|
|
session, err := cluster.CreateSession()
|
|
if err != nil {
|
|
return false
|
|
}
|
|
defer session.Close()
|
|
|
|
var dummy interface{}
|
|
err = session.Query("SELECT now() FROM system.local").WithContext(ctx).Scan(&dummy)
|
|
return err == nil
|
|
}
|
|
|
|
|
|
|
|
func (p *CassandraPlugin) identifyService(ctx context.Context, info *common.HostInfo) *ScanResult {
|
|
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
|
|
port, err := strconv.Atoi(info.Ports)
|
|
if err != nil {
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "cassandra",
|
|
Error: fmt.Errorf("无效的端口号: %s", info.Ports),
|
|
}
|
|
}
|
|
|
|
cluster := gocql.NewCluster(info.Host)
|
|
cluster.Port = port
|
|
timeout := time.Duration(common.Timeout) * time.Second
|
|
cluster.Timeout = timeout
|
|
cluster.ConnectTimeout = timeout
|
|
|
|
session, err := cluster.CreateSession()
|
|
if err != nil {
|
|
if strings.Contains(strings.ToLower(err.Error()), "authentication") {
|
|
banner := "Cassandra (需要认证)"
|
|
common.LogSuccess(fmt.Sprintf("Cassandra %s %s", target, banner))
|
|
return &ScanResult{
|
|
Success: true,
|
|
Service: "cassandra",
|
|
Banner: banner,
|
|
}
|
|
}
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "cassandra",
|
|
Error: err,
|
|
}
|
|
}
|
|
defer session.Close()
|
|
|
|
banner := "Cassandra"
|
|
common.LogSuccess(fmt.Sprintf("Cassandra %s %s", target, banner))
|
|
return &ScanResult{
|
|
Success: true,
|
|
Service: "cassandra",
|
|
Banner: banner,
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
func init() {
|
|
// 使用高效注册方式:直接传递端口信息,避免实例创建
|
|
RegisterPluginWithPorts("cassandra", func() Plugin {
|
|
return NewCassandraPlugin()
|
|
}, []int{9042, 9160, 7000, 7001})
|
|
} |