mirror of
https://github.com/shadow1ng/fscan.git
synced 2025-09-14 05:56:46 +08:00
8f54702c02
经Linus式架构审计，发现并修复插件系统中的具体问题： ## 核心修复 ### 1. 消除local插件GetPorts()方法冗余 - 删除21个local插件中无意义的GetPorts()方法 - 简化local.Plugin接口：移除端口概念 - 理由：本地插件不涉及网络，端口概念完全多余 ### 2. 消除web插件GetPorts()方法冗余 - 删除2个web插件中无用的GetPorts()方法 - 简化web.WebPlugin接口：专注智能HTTP检测 - 理由：Web插件使用动态HTTP检测，预定义端口无价值 ### 3. 统一插件命名规范 - 统一所有插件接口使用Name()方法（符合Go惯例） - 消除GetName()与Name()不一致问题 - 简化适配器：不再需要方法名转换 ## 技术改进 接口精简： - local插件：GetName() + GetPorts() → Name() - web插件：GetName() + GetPorts() → Name() - services插件：GetName() → Name()（保留GetPorts()，业务必需） 代码减少： - 删除23个无用GetPorts()方法 - 重命名52个Name()方法 - 简化3个插件接口定义 ## 影响范围 修改文件：55个插件文件 代码变更：-155行 +61行（净减少94行） 功能影响：零破坏性，保持所有业务逻辑不变 这是基于业务需求分析的精准重构，消除真正多余的部分， 保持系统架构合理性和向后兼容性。
125 lines
2.8 KiB
Go
125 lines
2.8 KiB
Go
package services
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/IBM/sarama"
|
|
"github.com/shadow1ng/fscan/common"
|
|
)
|
|
|
|
type KafkaPlugin struct {
|
|
name string
|
|
ports []int
|
|
}
|
|
|
|
func NewKafkaPlugin() *KafkaPlugin {
|
|
return &KafkaPlugin{
|
|
name: "kafka",
|
|
ports: []int{9092, 9093, 9094},
|
|
}
|
|
}
|
|
|
|
func (p *KafkaPlugin) Name() string {
|
|
return p.name
|
|
}
|
|
|
|
func (p *KafkaPlugin) GetPorts() []int {
|
|
return p.ports
|
|
}
|
|
|
|
func (p *KafkaPlugin) Scan(ctx context.Context, info *common.HostInfo) *ScanResult {
|
|
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
|
|
|
|
if common.DisableBrute {
|
|
return p.identifyService(ctx, info)
|
|
}
|
|
|
|
credentials := GenerateCredentials("kafka")
|
|
if len(credentials) == 0 {
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "kafka",
|
|
Error: fmt.Errorf("没有可用的测试凭据"),
|
|
}
|
|
}
|
|
|
|
for _, cred := range credentials {
|
|
if client := p.testCredential(ctx, info, cred); client != nil {
|
|
client.Close()
|
|
common.LogSuccess(fmt.Sprintf("Kafka %s %s:%s", target, cred.Username, cred.Password))
|
|
return &ScanResult{
|
|
Success: true,
|
|
Service: "kafka",
|
|
Username: cred.Username,
|
|
Password: cred.Password,
|
|
}
|
|
}
|
|
}
|
|
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "kafka",
|
|
Error: fmt.Errorf("未发现弱密码"),
|
|
}
|
|
}
|
|
|
|
|
|
func (p *KafkaPlugin) testCredential(ctx context.Context, info *common.HostInfo, cred Credential) sarama.Client {
|
|
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
|
|
timeout := time.Duration(common.Timeout) * time.Second
|
|
|
|
config := sarama.NewConfig()
|
|
config.Net.DialTimeout = timeout
|
|
config.Net.ReadTimeout = timeout
|
|
config.Net.WriteTimeout = timeout
|
|
config.Version = sarama.V2_0_0_0
|
|
|
|
if cred.Username != "" || cred.Password != "" {
|
|
config.Net.SASL.Enable = true
|
|
config.Net.SASL.Mechanism = sarama.SASLTypePlaintext
|
|
config.Net.SASL.User = cred.Username
|
|
config.Net.SASL.Password = cred.Password
|
|
config.Net.SASL.Handshake = true
|
|
}
|
|
|
|
brokers := []string{target}
|
|
client, err := sarama.NewClient(brokers, config)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
return client
|
|
}
|
|
|
|
|
|
|
|
func (p *KafkaPlugin) identifyService(ctx context.Context, info *common.HostInfo) *ScanResult {
|
|
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
|
|
|
|
emptyCred := Credential{Username: "", Password: ""}
|
|
client := p.testCredential(ctx, info, emptyCred)
|
|
if client == nil {
|
|
return &ScanResult{
|
|
Success: false,
|
|
Service: "kafka",
|
|
Error: fmt.Errorf("无法连接到Kafka服务"),
|
|
}
|
|
}
|
|
defer client.Close()
|
|
|
|
banner := "Kafka"
|
|
common.LogSuccess(fmt.Sprintf("Kafka %s %s", target, banner))
|
|
return &ScanResult{
|
|
Success: true,
|
|
Service: "kafka",
|
|
Banner: banner,
|
|
}
|
|
}
|
|
|
|
func init() {
|
|
// 使用高效注册方式：直接传递端口信息，避免实例创建
|
|
RegisterPluginWithPorts("kafka", func() Plugin {
|
|
return NewKafkaPlugin()
|
|
}, []int{9092, 9093, 9094})
|
|
} |