fscan/plugins/services/snmp.go
ZacharyZcR 8f54702c02 refactor: 精准修复插件系统三个设计问题
经Linus式架构审计,发现并修复插件系统中的具体问题:

## 核心修复

### 1. 消除local插件GetPorts()方法冗余
- 删除21个local插件中无意义的GetPorts()方法
- 简化local.Plugin接口:移除端口概念
- 理由:本地插件不涉及网络,端口概念完全多余

### 2. 消除web插件GetPorts()方法冗余
- 删除2个web插件中无用的GetPorts()方法
- 简化web.WebPlugin接口:专注智能HTTP检测
- 理由:Web插件使用动态HTTP检测,预定义端口无价值

### 3. 统一插件命名规范
- 统一所有插件接口使用Name()方法(符合Go惯例)
- 消除GetName()与Name()不一致问题
- 简化适配器:不再需要方法名转换

## 技术改进

接口精简:
- local插件:GetName() + GetPorts() → Name()
- web插件:GetName() + GetPorts() → Name()
- services插件:GetName() → Name()(保留GetPorts(),业务必需)

代码减少:
- 删除23个无用GetPorts()方法
- 重命名52个Name()方法
- 简化3个插件接口定义

## 影响范围

修改文件:55个插件文件
代码变更:-155行 +61行(净减少94行)
功能影响:零破坏性,保持所有业务逻辑不变

这是基于业务需求分析的精准重构,消除真正多余的部分,
保持系统架构合理性和向后兼容性。
2025-08-26 20:38:39 +08:00

156 lines
3.3 KiB
Go

package services
import (
"context"
"encoding/hex"
"fmt"
"net"
"time"
"github.com/shadow1ng/fscan/common"
)
type SNMPPlugin struct {
name string
ports []int
}
func NewSNMPPlugin() *SNMPPlugin {
return &SNMPPlugin{
name: "snmp",
ports: []int{161, 162},
}
}
func (p *SNMPPlugin) Name() string {
return p.name
}
func (p *SNMPPlugin) GetPorts() []int {
return p.ports
}
func (p *SNMPPlugin) Scan(ctx context.Context, info *common.HostInfo) *ScanResult {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
if common.DisableBrute {
return p.identifyService(ctx, info)
}
credentials := GenerateCredentials("snmp")
if len(credentials) == 0 {
return &ScanResult{
Success: false,
Service: "snmp",
Error: fmt.Errorf("没有可用的测试凭据"),
}
}
for _, cred := range credentials {
if p.testCredential(ctx, info, cred) {
common.LogSuccess(fmt.Sprintf("SNMP %s %s", target, cred.Username))
return &ScanResult{
Success: true,
Service: "snmp",
Username: cred.Username,
Password: "",
}
}
}
return &ScanResult{
Success: false,
Service: "snmp",
Error: fmt.Errorf("未发现弱团体字符串"),
}
}
func (p *SNMPPlugin) testCredential(ctx context.Context, info *common.HostInfo, cred Credential) bool {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
conn, err := net.DialTimeout("udp", target, time.Duration(common.Timeout)*time.Second)
if err != nil {
return false
}
defer conn.Close()
packet := p.buildSNMPGetRequest(cred.Username, "1.3.6.1.2.1.1.1.0")
conn.SetWriteDeadline(time.Now().Add(time.Duration(common.Timeout) * time.Second))
if _, err := conn.Write(packet); err != nil {
return false
}
conn.SetReadDeadline(time.Now().Add(time.Duration(common.Timeout) * time.Second))
response := make([]byte, 1024)
n, err := conn.Read(response)
if err != nil {
return false
}
return p.isValidSNMPResponse(response[:n])
}
func (p *SNMPPlugin) buildSNMPGetRequest(community, oid string) []byte {
template := "302902010004067075626c6963a01c02020f7102010002010030113015060a2b060102010101000500"
packet, err := hex.DecodeString(template)
if err != nil {
return nil
}
return packet
}
func (p *SNMPPlugin) isValidSNMPResponse(data []byte) bool {
if len(data) < 10 {
return false
}
return data[0] == 0x30
}
func (p *SNMPPlugin) identifyService(ctx context.Context, info *common.HostInfo) *ScanResult {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
cred := Credential{Username: "public", Password: ""}
if p.testCredential(ctx, info, cred) {
banner := "SNMP网络管理服务 (public团体可访问)"
common.LogSuccess(fmt.Sprintf("SNMP %s %s", target, banner))
return &ScanResult{
Success: true,
Service: "snmp",
Banner: banner,
}
}
conn, err := net.DialTimeout("udp", target, time.Duration(common.Timeout)*time.Second)
if err != nil {
return &ScanResult{
Success: false,
Service: "snmp",
Error: err,
}
}
defer conn.Close()
banner := "SNMP网络管理服务"
common.LogSuccess(fmt.Sprintf("SNMP %s %s", target, banner))
return &ScanResult{
Success: true,
Service: "snmp",
Banner: banner,
}
}
func init() {
// 使用高效注册方式:直接传递端口信息,避免实例创建
RegisterPluginWithPorts("snmp", func() Plugin {
return NewSNMPPlugin()
}, []int{161, 162})
}