fscan/plugins/services/vnc.go
ZacharyZcR 8f54702c02 refactor: 精准修复插件系统三个设计问题
经Linus式架构审计,发现并修复插件系统中的具体问题:

## 核心修复

### 1. 消除local插件GetPorts()方法冗余
- 删除21个local插件中无意义的GetPorts()方法
- 简化local.Plugin接口:移除端口概念
- 理由:本地插件不涉及网络,端口概念完全多余

### 2. 消除web插件GetPorts()方法冗余
- 删除2个web插件中无用的GetPorts()方法
- 简化web.WebPlugin接口:专注智能HTTP检测
- 理由:Web插件使用动态HTTP检测,预定义端口无价值

### 3. 统一插件命名规范
- 统一所有插件接口使用Name()方法(符合Go惯例)
- 消除GetName()与Name()不一致问题
- 简化适配器:不再需要方法名转换

## 技术改进

接口精简:
- local插件:GetName() + GetPorts() → Name()
- web插件:GetName() + GetPorts() → Name()
- services插件:GetName() → Name()(保留GetPorts(),业务必需)

代码减少:
- 删除23个无用GetPorts()方法
- 重命名52个Name()方法
- 简化3个插件接口定义

## 影响范围

修改文件:55个插件文件
代码变更:-155行 +61行(净减少94行)
功能影响:零破坏性,保持所有业务逻辑不变

这是基于业务需求分析的精准重构,消除真正多余的部分,
保持系统架构合理性和向后兼容性。
2025-08-26 20:38:39 +08:00

276 lines
5.5 KiB
Go

package services
import (
"context"
"crypto/des"
"encoding/binary"
"fmt"
"net"
"strings"
"time"
"github.com/shadow1ng/fscan/common"
)
type VNCPlugin struct {
name string
ports []int
}
func NewVNCPlugin() *VNCPlugin {
return &VNCPlugin{
name: "vnc",
ports: []int{5900, 5901, 5902, 5903, 5904, 5905, 5906, 5907, 5908, 5909},
}
}
func (p *VNCPlugin) Name() string {
return p.name
}
func (p *VNCPlugin) GetPorts() []int {
return p.ports
}
func (p *VNCPlugin) Scan(ctx context.Context, info *common.HostInfo) *ScanResult {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
if common.DisableBrute {
return p.identifyService(ctx, info)
}
if result := p.testUnauthAccess(ctx, info); result != nil && result.Success {
common.LogSuccess(fmt.Sprintf("VNC %s 未授权访问", target))
return result
}
credentials := GenerateCredentials("vnc")
if len(credentials) == 0 {
return &ScanResult{
Success: false,
Service: "vnc",
Error: fmt.Errorf("没有可用的测试凭据"),
}
}
for _, cred := range credentials {
if p.testCredential(ctx, info, cred) {
common.LogSuccess(fmt.Sprintf("VNC %s %s", target, cred.Password))
return &ScanResult{
Success: true,
Service: "vnc",
Username: "",
Password: cred.Password,
}
}
}
return &ScanResult{
Success: false,
Service: "vnc",
Error: fmt.Errorf("未发现弱密码"),
}
}
func (p *VNCPlugin) testUnauthAccess(ctx context.Context, info *common.HostInfo) *ScanResult {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
conn, err := net.DialTimeout("tcp", target, time.Duration(common.Timeout)*time.Second)
if err != nil {
return nil
}
defer conn.Close()
conn.SetDeadline(time.Now().Add(time.Duration(common.Timeout) * time.Second))
_, err = p.performHandshake(conn)
if err != nil {
return nil
}
authTypes, err := p.readAuthTypes(conn)
if err != nil {
return nil
}
for _, authType := range authTypes {
if authType == 1 {
return &ScanResult{
Success: true,
Service: "vnc",
Banner: "未授权访问",
}
}
}
return nil
}
func (p *VNCPlugin) testCredential(ctx context.Context, info *common.HostInfo, cred Credential) bool {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
conn, err := net.DialTimeout("tcp", target, time.Duration(common.Timeout)*time.Second)
if err != nil {
return false
}
defer conn.Close()
conn.SetDeadline(time.Now().Add(time.Duration(common.Timeout) * time.Second))
_, err = p.performHandshake(conn)
if err != nil {
return false
}
authTypes, err := p.readAuthTypes(conn)
if err != nil {
return false
}
var hasVNCAuth bool
for _, authType := range authTypes {
if authType == 2 {
hasVNCAuth = true
break
}
}
if !hasVNCAuth {
return false
}
if _, err := conn.Write([]byte{2}); err != nil {
return false
}
challenge := make([]byte, 16)
if _, err := conn.Read(challenge); err != nil {
return false
}
key := make([]byte, 8)
copy(key, []byte(cred.Password))
response, err := p.encryptChallenge(challenge, key)
if err != nil {
return false
}
if _, err := conn.Write(response); err != nil {
return false
}
result := make([]byte, 4)
if _, err := conn.Read(result); err != nil {
return false
}
return binary.BigEndian.Uint32(result) == 0
}
func (p *VNCPlugin) performHandshake(conn net.Conn) (string, error) {
versionBuf := make([]byte, 12)
if _, err := conn.Read(versionBuf); err != nil {
return "", err
}
version := strings.TrimSpace(string(versionBuf))
if _, err := conn.Write(versionBuf); err != nil {
return "", err
}
return version, nil
}
func (p *VNCPlugin) readAuthTypes(conn net.Conn) ([]byte, error) {
countBuf := make([]byte, 1)
if _, err := conn.Read(countBuf); err != nil {
return nil, err
}
count := countBuf[0]
if count == 0 {
return nil, fmt.Errorf("无可用认证类型")
}
authTypes := make([]byte, count)
if _, err := conn.Read(authTypes); err != nil {
return nil, err
}
return authTypes, nil
}
func (p *VNCPlugin) encryptChallenge(challenge, key []byte) ([]byte, error) {
reversedKey := make([]byte, 8)
for i := 0; i < 8; i++ {
reversedKey[i] = p.reverseBits(key[i])
}
cipher, err := des.NewCipher(reversedKey)
if err != nil {
return nil, err
}
response := make([]byte, 16)
cipher.Encrypt(response[0:8], challenge[0:8])
cipher.Encrypt(response[8:16], challenge[8:16])
return response, nil
}
func (p *VNCPlugin) reverseBits(b byte) byte {
var result byte
for i := 0; i < 8; i++ {
result = (result << 1) | ((b >> i) & 1)
}
return result
}
func (p *VNCPlugin) identifyService(ctx context.Context, info *common.HostInfo) *ScanResult {
target := fmt.Sprintf("%s:%s", info.Host, info.Ports)
conn, err := net.DialTimeout("tcp", target, time.Duration(common.Timeout)*time.Second)
if err != nil {
return &ScanResult{
Success: false,
Service: "vnc",
Error: err,
}
}
defer conn.Close()
conn.SetDeadline(time.Now().Add(time.Duration(common.Timeout) * time.Second))
version, err := p.performHandshake(conn)
if err != nil {
return &ScanResult{
Success: false,
Service: "vnc",
Error: err,
}
}
banner := fmt.Sprintf("VNC远程桌面服务 (%s)", version)
common.LogSuccess(fmt.Sprintf("VNC %s %s", target, banner))
return &ScanResult{
Success: true,
Service: "vnc",
Banner: banner,
}
}
func init() {
// 使用高效注册方式:直接传递端口信息,避免实例创建
RegisterPluginWithPorts("vnc", func() Plugin {
return NewVNCPlugin()
}, []int{5900, 5901, 5902, 5903, 5904, 5905, 5906, 5907, 5908, 5909})
}