Merge pull request #52 from npt-1707/fix_CVE-2023-50471

Fix potential vulnerable cloned function
src/utils/cJSON.cpp: add NULL check in cJSON_InsertItemInArray
2025-09-14 13:56:49 +08:00 · 2025-06-04 10:01:34 +08:00 · 2025-05-23 03:24:55 +08:00
1 changed files with 5 additions and 1 deletions
--- a/src/utils/cJSON.cpp
+++ b/src/utils/cJSON.cpp
@ -2142,7 +2142,7 @@ CJSON_PUBLIC(void) cJSON_InsertItemInArray(cJSON *array, int which, cJSON *newit
 {
    cJSON *after_inserted = NULL;

-    if (which < 0)
+    if (which < 0 || newitem == NULL)
    {
        return;
    }
@ -2154,6 +2154,10 @@ CJSON_PUBLIC(void) cJSON_InsertItemInArray(cJSON *array, int which, cJSON *newit
        return;
    }

+    if (after_inserted != array->child && newitem->prev == NULL) {
+        return;
+    }
+
    newitem->next = after_inserted;
    newitem->prev = after_inserted->prev;
    after_inserted->prev = newitem;
Author	SHA1	Message	Date
TaurusXin	80a607a8fb	Merge pull request #52 from npt-1707/fix_CVE-2023-50471 Some checks failed CI / build_on_windows_msys2 (push) Has been cancelled Details CI / build_on_windows_msvc (push) Has been cancelled Details CI / build_on_linux_amd64 (push) Has been cancelled Details CI / build_on_macos_amd64 (push) Has been cancelled Details CI / build_on_macos_arm64 (push) Has been cancelled Details Fix potential vulnerable cloned function	2025-06-04 10:01:34 +08:00
npt-1707	6c125d6152	src/utils/cJSON.cpp: add NULL check in cJSON_InsertItemInArray	2025-05-23 03:24:55 +08:00