chore: some cleanup everywhere

src/WallpaperEngine/FileSystem/Adapters/Virtual.h

@@ -23,7 +23,7 @@ struct VirtualAdapter final : Adapter {
     [[nodiscard]] std::filesystem::path physicalPath (const std::filesystem::path& path) const override;
 
     void add (const std::filesystem::path& path, const char* data);
-    void add (const std::filesystem::path& path, const JSON& contents);
+    void add (const std::filesystem::path& path, const JSON& data);
     void add (const std::filesystem::path& path, const std::string& data);
     void add (const std::filesystem::path& path, MemoryStreamSharedPtr stream);
 

src/WallpaperEngine/Render/Drivers/Detectors/X11FullScreenDetector.cpp

@@ -39,7 +39,7 @@ X11FullScreenDetector::X11FullScreenDetector (
     try {
         // attempt casting to CGLFWOpenGLDriver, this will throw if it's not possible
         // so we can gracely handle the error
-        dynamic_cast <GLFWOpenGLDriver&> (this->m_driver);
+        std::ignore = dynamic_cast <GLFWOpenGLDriver&> (this->m_driver);
     } catch (std::exception&) {
         sLog.exception ("X11 FullScreen Detector initialized with the wrong video driver... This is a bug...");
     }

src/WallpaperEngine/Render/FBOProvider.cpp

@@ -44,10 +44,9 @@ std::shared_ptr<CFBO> FBOProvider::alias (const std::string& newName, const std:
 }
 
 std::shared_ptr<CFBO> FBOProvider::find (const std::string& name) const {
-    const auto it = this->m_fbos.find (name);
+    if (const auto it = this->m_fbos.find (name); it != this->m_fbos.end ()) {
-
-    if (it != this->m_fbos.end ())
         return it->second;
+    }
 
     if (this->m_parent == nullptr) {
         return nullptr;

src/WallpaperEngine/Render/Objects/Effects/CPass.cpp

@@ -431,12 +431,12 @@ void CPass::setupShaders () {
         this->m_pass.textures, this->m_override.textures, this->m_override.constants
     );
 
-    const auto shaders = Shaders::GLSLContext::get ().toGlsl (
+    const auto [vertex, fragment] = Shaders::GLSLContext::get ().toGlsl (
         this->m_shader->vertex (), this->m_shader->fragment ());
 
     // compile the shaders
-    const GLuint vertexShaderID = compileShader (shaders.first.c_str (), GL_VERTEX_SHADER);
+    const GLuint vertexShaderID = compileShader (vertex.c_str (), GL_VERTEX_SHADER);
-    const GLuint fragmentShaderID = compileShader (shaders.second.c_str (), GL_FRAGMENT_SHADER);
+    const GLuint fragmentShaderID = compileShader (fragment.c_str (), GL_FRAGMENT_SHADER);
     // create the final program
     this->m_programID = glCreateProgram ();
     // link the shaders together

src/WallpaperEngine/Render/Shaders/GLSLContext.cpp

@@ -105,15 +105,15 @@ TBuiltInResource BuiltInResource = {
     .maxTaskWorkGroupSizeZ_NV = 1,
     .maxMeshViewCountNV = 4,
     .limits = {
-        .nonInductiveForLoops = 1,
+        .nonInductiveForLoops = true,
-        .whileLoops = 1,
+        .whileLoops = true,
-        .doWhileLoops = 1,
+        .doWhileLoops = true,
-        .generalUniformIndexing = 1,
+        .generalUniformIndexing = true,
-        .generalAttributeMatrixVectorIndexing = 1,
+        .generalAttributeMatrixVectorIndexing = true,
-        .generalVaryingIndexing = 1,
+        .generalVaryingIndexing = true,
-        .generalSamplerIndexing = 1,
+        .generalSamplerIndexing = true,
-        .generalVariableIndexing = 1,
+        .generalVariableIndexing = true,
-        .generalConstantMatrixVectorIndexing = 1,
+        .generalConstantMatrixVectorIndexing = true,
     }
 };
 

src/WallpaperEngine/Render/Shaders/Shader.cpp

@@ -38,7 +38,6 @@ Shader::Shader (
     this->m_fragment.linkToUnit (&this->m_vertex);
 }
 
-
 const std::string& Shader::vertex () {
     return this->m_vertex.compile ();
 }
@@ -59,7 +58,7 @@ const std::map<std::string, int>& Shader::getCombos () const {
     return this->m_combos;
 }
 
-Shader::ParameterSearchResult Shader::findParameter (const std::string& name) {
+Shader::ParameterSearchResult Shader::findParameter (const std::string& name) const {
     Variables::ShaderVariable* vertex = nullptr;
     Variables::ShaderVariable* fragment = nullptr;
 

src/WallpaperEngine/Render/Shaders/Shader.h

@@ -70,7 +70,7 @@ class Shader {
      * @param name
      * @return
      */
-    [[nodiscard]] ParameterSearchResult findParameter (const std::string& name);
+    [[nodiscard]] ParameterSearchResult findParameter (const std::string& name) const;
 
   private:
     /**

src/WallpaperEngine/Render/Wallpapers/CVideo.h

@@ -9,7 +9,7 @@ namespace WallpaperEngine::Render::Wallpapers {
 class CVideo final : public CWallpaper {
   public:
     CVideo (
-        const Wallpaper& video, RenderContext& context, AudioContext& audioContext,
+        const Wallpaper& wallpaper, RenderContext& context, AudioContext& audioContext,
         const WallpaperState::TextureUVsScaling& scalingMode,
         const uint32_t& clampMode);
 

src/WallpaperEngine/WebBrowser/CEF/WPSchemeHandlerFactory.h

@@ -4,7 +4,7 @@
 #include "include/cef_scheme.h"
 
 namespace WallpaperEngine::Data::Model {
-class Project;
+struct Project;
 }
 
 namespace WallpaperEngine::WebBrowser::CEF {

tools/linting.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
 shopt -s globstar
-clang-tidy --format-style file src/**/*.cpp -p cmake-build-debug
+clang-tidy --format-style file src/WallpaperEngine/**/*.cpp src/*.cpp src/Steam/**/*.cpp -p cmake-build-debug